Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use copy-from for large yeast jars, general fixes to yeast cultures #4352

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Mar 14, 2024

Purpose of change

A review from the future after I'd already merged #4348 pointed out a good idea.

And then I spotted some obvious mistakes in the old jar of yeast items so this turned into some general fixes.

Describe the solution

  1. Defined weight and volume for jar version. Went with weight matching volume since the flash version does that.
  2. Set the wild yeast item to copy from the jar version instead since it yields a jar when activated.
  3. Updated names to indicate size.
  4. Moved the 3-liter version up to where the others are and converted it to use copy-from.
  5. Updated the time requirements for larger batches. The jars take twice as long as the flask while the 3-liter jar takes the same amount of time the wild yeast uses (which is 6 times that of a flask). Also have the different times spelled out in a comment for each.
  6. Misc: fixed some misspellings in item description for wild yeast.

Describe alternatives you've considered

We could tone down the time taken for the wild yeast to grow and/or bump up the yield. 3 days for only 2 units of yeast seems extreme but dunno what numbers to go with instead.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Load-tested in compiled test build.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Mar 14, 2024
@chaosvolt chaosvolt changed the title fix: use copy-from for large yeast jars, general fixes to yeast cul… fix: use copy-from for large yeast jars, general fixes to yeast cultures Mar 14, 2024
@scarf005 scarf005 merged commit bc5beca into cataclysmbnteam:main Mar 15, 2024
10 checks passed
@chaosvolt chaosvolt deleted the you-are-going-in-the-jar branch March 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants