Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): the armored wheel is now off-road #4363

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

cthae
Copy link
Contributor

@cthae cthae commented Mar 17, 2024

Purpose of change

The 32' armored wheel looks like so:

It is off-road.

It's also the best wheel the base game has to offer for your typical mobile base. It's difficult to find, difficult to take off and difficult to install.

Describe the solution

Changing the type from normal to off-road.

Describe alternatives you've considered

A mod. I have a mod doing it, but it makes sense for this to be in the base game.

Testing

Drive a vehicle with 32' armored wheels on rough terrain and compare the max speed/acceleration.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Mar 17, 2024
chaosvolt
chaosvolt previously approved these changes Mar 17, 2024
@chaosvolt chaosvolt dismissed their stale review March 17, 2024 20:06

Oh right the vehicle tests augh I hate them

@scarf005
Copy link
Member

- https://upload.wikimedia.org/wikipedia/commons/4/41/Irish_Army_RG-32M_Light_Tactical_Armoured_Vehicle_LTAV_(4520429843).jpg
+ ![](https://upload.wikimedia.org/wikipedia/commons/4/41/Irish_Army_RG-32M_Light_Tactical_Armoured_Vehicle_LTAV_(4520429843).jpg)

please use markdown image syntax to display images.

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#images

@github-actions github-actions bot added the tests changes related to tests label Mar 18, 2024
@chaosvolt
Copy link
Member

Okay, let's see if that takes care of all the tests...

@scarf005
Copy link
Member

./build/tests/cata_test-tiles vehicle_efficiency
09:45:36.923 INFO : Randomness seeded to: 0
09:45:36.924 INFO : C locale on startup: 'ko_KR.UTF-8'
09:45:36.924 INFO : C++ locale on startup: 'ko_KR.UTF-8'
09:45:36.924 WARNING : Failed to detect system UI language.
09:45:36.925 INFO : Number of render drivers on your system: 3
09:45:36.925 INFO : Render driver: 0/opengl
09:45:36.925 INFO : Render driver: 1/opengles2
09:45:36.925 INFO : Render driver: 2/software
09:45:36.926 INFO : Set debug classes to: [DEBUGMSG MAIN LUA]

Starting the actual test at Mon Mar 18 09:45:43 2024
Filters: vehicle_efficiency
===============================================================================
All tests passed (178668 assertions in 1 test case)

Ended test at Mon Mar 18 09:45:48 2024
The test took 4.458 seconds

local tests pass.

@scarf005 scarf005 merged commit e49d4a0 into cataclysmbnteam:main Mar 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants