Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dead state persisting between worlds #4368

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix: dead state persisting between worlds #4368

merged 1 commit into from
Mar 19, 2024

Conversation

scarf005
Copy link
Member

Purpose of change

Describe the solution

on loading player character, reset its cached_dead_state.

Describe alternatives you've considered

Testing

  1. kill yourself.
  2. load another character in other world.
  3. check that the character is alive.

@scarf005
fix: dead state persisting between worlds
546128c 
reset dead state after loading player
@scarf005 scarf005 requested a review from chaosvolt March 19, 2024 03:20
@github-actions github-actions bot added the src changes related to source code. label Mar 19, 2024
@scarf005 scarf005 merged commit 41bb5f2 into cataclysmbnteam:main Mar 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaosvolt chaosvolt chaosvolt approved these changes

Assignees
No one assigned
Labels
src changes related to source code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New characters retain dead state from previously deceased characters
2 participants
@scarf005 @chaosvolt