Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Corrects charges draining from forges #5461

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

joveeater
Copy link
Collaborator

Checklist

Purpose of change

Fixes #3754

Describe the solution

Forges were trying to consume charges of the fake forge item itself (e.g. char_forge) instead of its ammo (e.g. charcoal).

Additional context

I'm not sure if this does relate to #5439. If someone could check if it's still present that would be great but I'm guessing it will be.

Also notice there's a very similar thing just above this (line 5099) for the power grid charge consumption. Again it's using the fake item as what it's depleting but I'm not sure if that's correct for power? Could you take a quick look @chaosvolt and make sure it's ok?

@github-actions github-actions bot added the src changes related to source code. label Sep 29, 2024
@scarf005 scarf005 self-requested a review September 29, 2024 13:03
@scarf005
Copy link
Member

scarf005 commented Sep 29, 2024

image

  1. spawned in rock kiln and charged it with 100 charcoals.
  2. crafted 1 clay jug which uses 80 kiln charges.
  3. confirmed only 20 charges left.

I'm not sure if this does relate to #5439.

i'm unable to reproduce this, maybe could ask @RoyalFox2140 who could reproduce it. (but how, like we both are using linux)

Also notice there's a very similar thing just above this (line 5099) for the power grid charge consumption. Again it's using the fake item as what it's depleting but I'm not sure if that's correct for power?

image

it seems to use grid charge correctly atm.

@scarf005 scarf005 merged commit a0a4346 into cataclysmbnteam:main Sep 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

charges not depleting in rock forges / clay kilns (possibly other tools)
2 participants