Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update antique shops, elephant guns are now reasonably obtainable #5786

Merged

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Dec 4, 2024

Checklist

Required

Purpose of change

Elephant guns are the only weapon to fire .700 nitro express and they were incredibly rare due to being buried in distributions. Your local antique shop now doubles as an elephant protection shop.

Describe the solution

All medieval weapons in antique_rare got moved to antique_medieval_arms which means now antique_rare is funny rocks and guns.

Describe alternatives you've considered

Convert to Collection but Chaos screamed in pain.

Testing

image

Additional context

I own an elephant gun for home protection because that's what the founding monster hunters intended. Four dragons break into my house "What the devil?" As I grab my elephant gun and funny baseball cap with an inappropriate slogan that won't age well. Blow a golf-ball size hole in the first dragon, its dead on the spot.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 4, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough improvement. Could also replace fixed gun spawns with nested gun groups at some point so they'll spawn with ammo.

@RoyalFox2140
Copy link
Collaborator Author

Seems simple enough improvement. Could also replace fixed gun spawns with nested gun groups at some point so they'll spawn with ammo.

I don't think that they would legally sell ammunition but that's a bit of realismic stuff we can probably ignore for now. Balance-wise I don't know if we want a lot of extra ammo.

@chaosvolt
Copy link
Member

Fair, might make more sense to be a thing added to other relevant locations assuming mansions and the like can't already spawn with ammo.

@chaosvolt chaosvolt merged commit 57e5e21 into cataclysmbnteam:main Dec 4, 2024
9 checks passed
@RoyalFox2140 RoyalFox2140 deleted the elephant-protection-shops branch December 4, 2024 04:33
@ZChris13
Copy link

ZChris13 commented Dec 4, 2024

I don't think that they would legally sell ammunition

Anybody can sell ammo currently in the US, the restrictions are on making it and then selling it as a business. Any state level restrictions would not survive the legal environment of the pre-Cataclysm backstory (where it's freshly legal to manufacture, trade and possess machine guns, but belt feds haven't proliferated yet, which requires a significant overton window shift and a conservative SCOTUS). @RoyalFox2140 you can always tag me if you need a hot take on guns/legality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants