Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Purpose of change
iuse.cpp
return an int value that indicates charges to be used from an item, but this wasn't properly being used due to a lack of consideration inuse_charges()
.Describe the solution
iuse::rpgdie
now returns 0 in all cases, preventing charges of rpgdie from being used.Describe alternatives you've considered
iuse::rpgdie
iuse_actor
later on so that you can define individual dice with fixed sides instead of each die being set randomly to being a d4, d8, d20, d50 etc.Testing
Additional context
I shudder to think what other bugs have been uncovered in the process. Most should be fixed with the energy rework, but that's going to break 50 other things I didn't account for I'm sure.