-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --skip-benchmarks command-line option. #2408
Added --skip-benchmarks command-line option. #2408
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #2408 +/- ##
=======================================
Coverage 91.13% 91.13%
=======================================
Files 157 157
Lines 7426 7430 +4
=======================================
+ Hits 6767 6771 +4
Misses 659 659 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs tests.
It should be enough to pick some TEST_CASE that's already in the SelfTest project and has benchmarks, and then add new CTest test that invokes SelfTest
with --skip-benchmarks
and test spec for that one test. The test then checks that the benchmark was skipped by looking for the benchmark output.
Or add a new TEST_CASE just for this, that way is more resilient to later changes.
- Added version placeholder in documentation - Improved description of as suggested
The new CTest runs a dedicated TEST_CASE with the --skip-benchmarks option. The TEST_CASE can only succeed when the two benchmarks inside are skipped.
Thanks. |
This PR adds the feature requested by #2392 "Command line option to skip benchmarks" by introducing the command-line option "--skip-benchmarks" so that Catch runs no benchmarks when this option is set. I'd be glad about feedback.