Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icons #14

Closed
quentinguidee opened this issue Dec 29, 2023 · 6 comments
Closed

Missing icons #14

quentinguidee opened this issue Dec 29, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@quentinguidee
Copy link
Member

quentinguidee commented Dec 29, 2023

Here's a summary of all icons that don't work yet.

If you want to add another icon here, please comment this issue and we'll update the table.

Icon Reason Status Issue
.html Needs to be added to extensions.ts Released with v1.4.0 #14
.py The Python plugin overrides our icon Released with v1.3.0 #19
.g4 No icons on vscode-icons Released with v1.2.0 #14
.vue Needs to be added to extensions.ts Released with v1.1.0 #13
.razor Needs to be added to extensions.ts #7
poetry.lock No icons on vscode-icons #7

Reasons:

  • Needs to be added to extensions.ts: The extension is not mapped in extensions.ts. You can send a pull request to the repo to update that, and we'll update that here.
  • No icons on vscode-icons: The icon is not done yet in catppuccin/vscode-icons, which is the repository from which we pull the icons for this Jetbrains extension.
  • Unknown: ¯\_(ツ)_/¯
@ricardoboss
Copy link

I'd like to see .g4 (ANTLRv4) in this plugin too. I created a PR over at vscode-icons: catppuccin/vscode-icons#66

@michael-farwell
Copy link

.html seems to be missing. Not sure if it was missing before 1.3.0.
Screenshot 2024-02-26 at 6 14 02 AM

@quentinguidee
Copy link
Member Author

.html seems to be missing. Not sure if it was missing before 1.3.0.

Oh yep! Thanks! The vscode extension uses another technique to detect html files, and I think they removed recently the html extension for this reason. This should be fixed soon: catppuccin/vscode-icons#112

@quentinguidee
Copy link
Member Author

Fixed on JetBrains Icons (#30), a release will follow in a couple of days.

For now you can also install it manually: https://github.com/catppuccin/jetbrains-icons/actions/runs/8051436394

@quentinguidee
Copy link
Member Author

I forgot to say that here but @michael-farwell the 1.4.0 is released on the marketplace with the fix for html files!

@sgoudham
Copy link
Contributor

sgoudham commented Aug 7, 2024

Going to close this issue in favour of letting people raise individual issues for icons as I think it's much easier to track and manage.

The poetry icon is tracked in catppuccin/vscode-icons#169 and .razor needs to be raised as an issue in the vscode-icons repository.

@sgoudham sgoudham closed this as completed Aug 7, 2024
@sgoudham sgoudham unpinned this issue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants