Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for kitty #19

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Apr 15, 2023

this adds support for the kitty theme

i was also thinking of maybe making a utils file like my previous prs, but with general functions others might need to use (like with mkUpper in this case since it's also used by the gtk hm module). let me know what you think :)

@Stonks3141 Stonks3141 enabled auto-merge (squash) April 15, 2023 23:40
@Stonks3141 Stonks3141 merged commit bdc4336 into catppuccin:main Apr 15, 2023
Copy link
Member

@Stonks3141 Stonks3141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

# this capitalizes the first letter in a string
# it's used to set the theme name correctly here
mkUpper = word:
(toUpper (substring 0 1 word)) + (substring 1 (stringLength word) word);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this into a utils.nix or something? Maybe also the flavour and accent types.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was thinking of something like that as well
maybe with a mkCatppuccinOption function too in order to get rid of the boilerplate from the first part of the files all together?

@getchoo getchoo deleted the add-kitty branch April 16, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants