Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(home-manager)!: add support for global cursors #195

Merged
merged 2 commits into from
Jun 25, 2024
Merged

feat(home-manager)!: add support for global cursors #195

merged 2 commits into from
Jun 25, 2024

Conversation

Weathercold
Copy link
Contributor

Closes #158

getchoo
getchoo requested changes May 28, 2024
View reviewed changes
modules/home-manager/home.nix Outdated Show resolved Hide resolved
modules/home-manager/home.nix Outdated Show resolved Hide resolved
dixslyf
dixslyf suggested changes Jun 7, 2024
View reviewed changes
modules/home-manager/home.nix Outdated Show resolved Hide resolved
@getchoo getchoo mentioned this pull request Jun 19, 2024
Merged
@isabelroses isabelroses mentioned this pull request Jun 21, 2024
Closed
@getchoo getchoo added this to the 1.0.0 milestone Jun 23, 2024
@getchoo getchoo force-pushed the home-pointer-cursor branch from 4f588cf to 392aff9 Compare June 23, 2024 02:04
@getchoo getchoo changed the title feat(home-manager): add support for global cursors feat(home-manager)!: add support for global cursors Jun 23, 2024
@getchoo
Copy link
Member

getchoo commented Jun 23, 2024

i've adopted the new option naming in the catppuccin namespace as discussed above, and also made this a replacement for the original gtk module. this will resolve deprecation warnings for those only using that (as it's not actually deprecated or archived like the upstream gtk port) and prevent this PR from introducing another option that basically does the same thing as the old one

isabelroses
isabelroses reviewed Jun 23, 2024
View reviewed changes
modules/home-manager/gtk.nix Show resolved Hide resolved
modules/home-manager/gtk.nix Outdated Show resolved Hide resolved
@getchoo getchoo mentioned this pull request Jun 25, 2024
Closed
@getchoo getchoo force-pushed the home-pointer-cursor branch from 392aff9 to 5e81f96 Compare June 25, 2024 02:35
@getchoo
Copy link
Member

getchoo commented Jun 25, 2024

thanks!

@getchoo getchoo merged commit 6e77fdd into catppuccin:main Jun 25, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
Merged
@Weathercold Weathercold deleted the home-pointer-cursor branch July 25, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@versedwildcat versedwildcat versedwildcat left review comments

@isabelroses isabelroses isabelroses left review comments

@dixslyf dixslyf dixslyf requested changes

@getchoo getchoo getchoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

split cursors into separate module
5 participants
@Weathercold @getchoo @dixslyf @isabelroses @versedwildcat