Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nixos): add support for fcitx5 #221

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

Zh40Le1ZOOB
Copy link
Contributor

No description provided.

modules/nixos/fcitx5.nix Outdated Show resolved Hide resolved
@Zh40Le1ZOOB Zh40Le1ZOOB force-pushed the nixos-fcitx5 branch 3 times, most recently from a42156d to c1bc4ff Compare June 11, 2024 06:54
@Zh40Le1ZOOB Zh40Le1ZOOB requested a review from getchoo June 11, 2024 18:19
@Zh40Le1ZOOB
Copy link
Contributor Author

Hi, any update?

Copy link
Contributor

@Weathercold Weathercold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add i18n.inputMethod.enabled = "fcitx5"; in the nixos test

@Zh40Le1ZOOB
Copy link
Contributor Author

You should add i18n.inputMethod.enabled = "fcitx5"; in the nixos test

Thank you for review, done.

Copy link
Contributor

@Weathercold Weathercold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add your module to modules/nixos/all-modules.nix

modules/nixos/fcitx5.nix Outdated Show resolved Hide resolved
@Zh40Le1ZOOB Zh40Le1ZOOB force-pushed the nixos-fcitx5 branch 3 times, most recently from e767756 to ebf7c7b Compare August 6, 2024 06:39
@Zh40Le1ZOOB Zh40Le1ZOOB requested a review from Weathercold August 6, 2024 06:39
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait!

modules/nixos/fcitx5.nix Outdated Show resolved Hide resolved
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These reviews have apparently been pending for about a month...guess I forgot to hit submit 🤦🏻

modules/nixos/all-modules.nix Outdated Show resolved Hide resolved
modules/nixos/fcitx5.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@Weathercold Weathercold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add accent support (see #343 above), otherwise LGTM

@Zh40Le1ZOOB
Copy link
Contributor Author

You should add accent support (see #343 above), otherwise LGTM

Done, thanks for review.

@Zh40Le1ZOOB Zh40Le1ZOOB force-pushed the nixos-fcitx5 branch 2 times, most recently from 15c7c67 to e0bb6ff Compare September 30, 2024 10:36
Co-authored-by: Weathercold <weathercold.scr@proton.me>
Co-authored-by: seth <getchoo@tuta.io>
@getchoo getchoo changed the title feat(nixos): add fcitx5 module feat(nixos): add support for fcitx5 Nov 8, 2024
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry again for the wait!

@getchoo getchoo merged commit 309c49f into catppuccin:main Nov 8, 2024
6 checks passed
@Zh40Le1ZOOB
Copy link
Contributor Author

Thanks and sorry again for the wait!

Thank you very much!

@Zh40Le1ZOOB Zh40Le1ZOOB deleted the nixos-fcitx5 branch November 10, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants