-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nixos): add support for fcitx5 #221
Conversation
a42156d
to
c1bc4ff
Compare
c1bc4ff
to
46de48a
Compare
Hi, any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add i18n.inputMethod.enabled = "fcitx5";
in the nixos test
46de48a
to
e5b895f
Compare
Thank you for review, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add your module to modules/nixos/all-modules.nix
e767756
to
ebf7c7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the wait!
5ebbc36
to
d3191c0
Compare
3e6ba72
to
d3191c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These reviews have apparently been pending for about a month...guess I forgot to hit submit 🤦🏻
c4e33d1
to
331fdb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add accent support (see #343 above), otherwise LGTM
331fdb7
to
0f39371
Compare
Done, thanks for review. |
15c7c67
to
e0bb6ff
Compare
Co-authored-by: Weathercold <weathercold.scr@proton.me> Co-authored-by: seth <getchoo@tuta.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and sorry again for the wait!
Thank you very much! |
No description provided.