-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nixos/sddm): use the kde sddm package #230
Conversation
closes #229 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this would be better as an assertion...but i'm not really sure how to reliably do that as sddm doesn't directly report its qt's major version
my first thoughts are asserting that pkgs.kdePackages.qtbase is in the buildInputs of config.services.displayManager.sddm.package or making a conditionally applied assertion for services.displayManager.sddm.package via a new option
I think the easiest thing would be to check what package is being used since it's either the qt5 one or the kde package. |
or perhaps |
that's what i meant with a conditional assertion. it wouldn't account for overriden packages ofc, but if someone really knows what they're doing they can disable it with an option
i don't think it would as users could easily set the qt5 package as normal with no warning. assertions on the other hand provide a built in explanation of why we need to use the qt6 version when this happens
why would this happen? |
The duplicate package deceleration I mean. |
cec7753
to
4356873
Compare
the upstream port has moved to qt 6, while nixos' default is still qt 5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This resolves the error where the theme doesn't work if plasma6 isn't enabled. by default the packge is qt5 sddm, but catppuccin/sddm uses qt6.