Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(home-manager): assert qt.style.name for kvantum theme #242

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jun 25, 2024

while having qt.enable be a prerequisite for this option applying
makes sense, the requirement on a specific style.name is not. this
make it more clear by moving that check to an assertion rather than an
internal comparison

while having `qt.enable` be a prerequisite for this option applying
makes sense, the requirement on a specific `style.name` is not. this
make it more clear by moving that check to an assertion rather than an
internal comparison
@getchoo getchoo added this to the 1.0.0 milestone Jun 25, 2024
@vdbe
Copy link
Contributor

vdbe commented Jun 25, 2024

Is there a reason enablingqt.style.catppuccin does not set qt.style.name to kvantum itself.

If so I feel like this should be a warning.

@getchoo
Copy link
Member Author

getchoo commented Jun 25, 2024

Is there a reason enabling qt.style.catppuccin does not set qt.style.name to kvantum itself.

i feel some options would be better set for the user - with this being one of them. setting qt.style.catppuccin doesn't really give the user any hint that kvantum will be enabled, which can easily lead to issues where they may set it to something, then have a conflict to deal with that contains no real guidance on why it was set to kvantum

If so I feel like this should be a warning.

i don't feel a warning is appropriate here as it's a hard requirement. if we can know for sure something is broken (like in the case of kvantum not being used), we should throw an evaluation error as to make it obvious qt.style.catppuccin will not work if enabled. after all, why would a user enable it if they were okay with it not doing anything?

@getchoo getchoo merged commit 1adbfeb into catppuccin:main Jun 25, 2024
6 checks passed
@getchoo getchoo deleted the kvantum-assertion branch June 25, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants