-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim-illuminate better highlight groups #571
Comments
equire("catppuccin").setup({
integrations = {
illuminate = true,
}
}) |
Hi, I saw that and I have set int var = 0 // var background should have one color (var defined here)
var = 4; // another color
var = 3; // same color as line above Of course background colors olny show when you hover |
The problem is it's hard to come up with an another color that would please everyone. Maybe TextRead will have underline? Maybe TextWrite should use standout style? Dunno. If you can suggest your desire highlight definition I will happily add it under |
I see your point. Personally I used inverse colors (background and foreground colors inverted) for the definition because I wanted it to stand out as much as possible but even a different shade of grey would be fine I think ( darker for light theme an lighter for dark theme). A different shade would probably please most people, especially if the |
Ideally Text Should be white background and high visibility, like Write, while Read have a grey background. However, Text highlight is used by default when there is no LSP active for every occurrence of the word and I don't like to have such a strong background in that case, it's too distracting. It's probably a good compromise to have. Text and Read grey and Write in white background. |
Is your feature request related to a problem? Please describe.
vim-illuminate
can display different colors for variable definition/usage which helps reason about code quite a lot betterDescribe the solution you'd like
Integrate the highlight groups in the colorscheme
Describe alternatives you've considered
Define them manually but I think this should come with the colorscheme
Additional context
The highlight groups. The *Read and *Write highlight groups are the ones that get used when LSP information is available.
P.S.: the colorscheme is amazing, good job!
The text was updated successfully, but these errors were encountered: