Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoTree background does not blend with the WinSeparator as shown in README screenshots. #670

Closed
UtkarshVerma opened this issue Mar 1, 2024 · 5 comments · Fixed by #644
Closed
Labels
bug Something isn't working

Comments

@UtkarshVerma
Copy link

UtkarshVerma commented Mar 1, 2024

Description

In the screenshots, the background of NeoTree and the window separator is the same which gives a consistent look to the sidebar. It can be achieved by setting the fillchar appropriately.

vim.opts.fillchars.vert = "", -- Used for window separator.

I have to use the following custom_highlight to fix it:

      custom_highlights = function(colors)
        return {
          -- Make window separator blend with neo-tree.
          WinSeparator = { fg = colors.mantle, bg = colors.none },
        }
      end,

Neovim version

NVIM v0.9.5 
Build type: Release 
LuaJIT 2.1.1702233742 
 
   system vimrc file: "$VIM/sysinit.vim" 
  fall-back for $VIM: "/usr/share/nvim" 
 
Run :checkhealth for more info

Terminal and multiplexer

st

Catppuccin version / branch / rev

catppuccin v1.6.0

Steps to reproduce

Just open neovim and observe the separator.

Expected behavior

Window separator color is same as NeoTree background.

Actual behavior

The border looks different.

image

@UtkarshVerma UtkarshVerma added the bug Something isn't working label Mar 1, 2024
@mariesavch
Copy link

on screenshot is nvimtree with


neotree also has this like defined here
NeoTreeVertSplit = { fg = C.base, bg = inactive_bg },
but neotree catppuccin integration disabled by default (so just enable this integration in your config)

@UtkarshVerma
Copy link
Author

I had the integration for neotree turned on. Here is the repro.lua for this if you want to test:

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
	vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
	{
		"catppuccin/nvim",
		main = "catppuccin",
		opts = {
			integrations = {
				neotree = true,
			},
		},
	},

	{
		"nvim-neo-tree/neo-tree.nvim",
		dependencies = {
			{ "MunifTanjim/nui.nvim" },
			{ "nvim-lua/plenary.nvim" },
			{ "nvim-tree/nvim-web-devicons" },
		},
	},
	-- add any other plugins here
}
require("lazy").setup(plugins, {
	root = root .. "/plugins",
})

vim.opt.fillchars = { vert = "" }
vim.cmd.colorscheme("catppuccin")
-- add anything else here

@mariesavch
Copy link

tested its working with NeoTreeWinSeparator hightlight

@UtkarshVerma
Copy link
Author

So, would it be added upstream, or do I have to update my config?

@mariesavch
Copy link

for now you can use custom_hightlights
NeoTreeWinSeparator = { fg = colors.base, bg = colors.base }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants