Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ANSI Colours into CSS output #105

Open
TimoNotThy opened this issue Oct 31, 2024 · 2 comments · May be fixed by #109
Open

Add ANSI Colours into CSS output #105

TimoNotThy opened this issue Oct 31, 2024 · 2 comments · May be fixed by #109
Labels
enhancement New feature or request

Comments

@TimoNotThy
Copy link

TimoNotThy commented Oct 31, 2024

In the style guide bold colors are mentioned but they're not available in the css palette. Could they be added like --ctp-mocha-ansi-red for
mocha red

@unseen-ninja
Copy link
Member

Personally I've treated the ANSI colours as something that is not meant to be used in regular syling hence I figured that we don't really need it in the CSS and software pallettes. Tho I might be wrong. I guess technically it also doesn't hurt to have them in there?
What are your thoughts on this @sgoudham, @backwardspy?

@sgoudham
Copy link
Contributor

sgoudham commented Nov 1, 2024

It was on my mind to implement during #98 but I was pretty focused on the last minute edits that we did that I forgot to update the CSS/SCSS palettes before merging.

Whether or not there's a real use case for it, it's pretty trivial/simple to implement so happy to add it. We will most likely use it down the line for representing our style guide in a web based format... whenever that happens ;) @unseen-ninja

@sgoudham sgoudham changed the title Bold/ansi colors missing in css Add ANSI Colours into CSS/SCSS palettes Nov 1, 2024
@sgoudham sgoudham added the enhancement New feature or request label Nov 1, 2024
@sgoudham sgoudham changed the title Add ANSI Colours into CSS/SCSS palettes Add ANSI Colours into CSS output Nov 1, 2024
@sgoudham sgoudham linked a pull request Nov 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants