Added ANTLRv4 icon #66
Conversation
|
hi thanks for the contribution, however icon doesnt fit the style guidelines, i'll close the PR but keep the issue open and eventually do it :) |
|
But... the icon is 100 by 100. Where are the style guidelines? |
|
By the way: I put a lot of effort into editing the icon to match the style of the other icons and simply closing this PR without giving me feedback I can build upon is quite rude IMHO. |
|
never meant to, i just struggle with having PRs open that won't be merged atm so i try to avoid being overwhelmed. it's in the works to add a proper contributing guide with guidelines, but we're also smh working on changing them and the way the extension is (to add more customization for example). i added context on the issue you opened and you're still very welcome to re submit a fitting one |
|
I updated the icon according to your suggestions. I also simplified the source file so it is easier to read. |
|
This is how it looks in use in VS Code: |
|
@ricardoboss I'm not maintainer of this repo, but when comparing to other icons this still doesn't seem to follow the icons style: All lines should have the same weight, and the "A" here seems 3x more bold. The entire goal of this icons pack is to make all icons more uniform and coherent together; so maybe you can try reusing the "A" from the icon at the top right in this screen, and mirror it? 
|
|
I see what you mean, yeah. I tried to stay true to the original logo, but it may be better to adjust it even more. Let me work on it a bit more |
|
@quentinguidee @prazdevs what do you think? |
|
giga merged v1, and antlr icon will be available ! closing this |
Fixes #65