Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization: I'm looking for translators #303

Open
cbucher opened this issue Feb 8, 2016 · 23 comments
Open

Localization: I'm looking for translators #303

cbucher opened this issue Feb 8, 2016 · 23 comments

Comments

@cbucher
Copy link
Owner

cbucher commented Feb 8, 2016

If you want to contribute to this project as translator, you can see how here.

@cruzzer
Copy link

cruzzer commented Feb 14, 2016

You can put me down for German

@cruzzer
Copy link

cruzzer commented Feb 15, 2016

Hi Christophe,

I've create that translated ini file for German, but I'm currently not setup to with Visual Studio.
What would you want me to do?

Regards

@cbucher
Copy link
Owner Author

cbucher commented Feb 15, 2016

@cruzzer HI

Thank you for contributing.

So, you created the directory l10n/DEU and translated the file l10n/DEU/console.ini.
Have you generated the file l10n/DEU/console.rc?

The l10n project will automatically generate all localized dll by parsing l10n sub directories.
There is nothing to add in Visual Studio.

Do you have Visual Studio? Can you build the solution?

Regards

@cruzzer
Copy link

cruzzer commented Feb 17, 2016

Hi Christoph,

I've had some issues creating the console.rc file. Yes, it generated the console.rc file, but with the LocalizeRC error: "Could not copy file! The system cannot find the file specified."

I can commit the files and you can have a look at them. The fields only need re-sizing. Sadly I don't have Visual Studio.

Regards

@cbucher
Copy link
Owner Author

cbucher commented Feb 17, 2016

I've had some issues creating the console.rc file. Yes, it generated the console.rc file, but with the LocalizeRC error: "Could not copy file! The system cannot find the file specified."

console/resource.h is missing.
have you download all the project?

I can commit the files and you can have a look at them. The fields only need re-sizing. Sadly I don't have Visual Studio.

Visual Studio Community is free.
See https://github.com/cbucher/console/wiki/How-to-compile
There are links to all needed tools.

@cruzzer
Copy link

cruzzer commented Feb 18, 2016

I could not find iconv at the location you supplied, so is used the solution from here.

Once I've compiled the binaries. How do I start consoleZ with that specific language? It did create console_DEU.dll, but in the build window it mentiones "build target does not exist"

@cbucher
Copy link
Owner Author

cbucher commented Feb 19, 2016

I change iconv download location in the documentation.

Localized dll and console.exe must be in the same folder.
Localized dll and console.exe must have the same version.
Console.exe loads the localized dll corresponding to your current Windows language.
If you want to test another language, you must rename the localized dll (change the three-letters code).

So just copy (your choice upon your OS and target you are building):

  • the binaries bin\(Win32 or x64)\(Release or Debug)\*.* in localized dll into l10n\Release
  • the binaries bin\(Win32 or x64)\(Release Legacy or Debug Legacy)\*.* in localized dll into l10n\Release Legacy

And launch console.exe from l10n\Release or l10n\Release Legacy.

@cruzzer
Copy link

cruzzer commented Feb 23, 2016

I'm just uploading these files. Unfortunately I did not have success with consolez loading the dll.
german.zip

@cbucher
Copy link
Owner Author

cbucher commented Feb 24, 2016

Unfortunately I did not have success with consolez loading the dll.

I can see no problem if you respect these rules:

  • Localized dll and console.exe must be in the same folder.
  • Localized dll and console.exe must have the same version.
  • Console.exe loads the localized dll corresponding to your current Windows language.
  • If you want to test another language, you must rename the localized dll (change the three-letters code).

image

We must resolve your issue.

Please do a pull request.
The identity of the translator must appear in the commit. I wish not be responsible for the translation. I will not control that translation is correct and I will not maintainer.
You can add your name in the "about" window (the string can be found in console.ini).

@cruzzer
Copy link

cruzzer commented Feb 25, 2016

So I spent some more time on it. It seams I had two problems that masked each other.

  1. My iconv.exe produces an incorrect output and the build process didn't give me an error for that, so I didn't detect it. Once I replaced my version with yours, I got an error that stuff was missing.
  2. The missing RES folder might be generated by LocalizeRC, but is not included in your committed project. To remedy that I included the console project in the l10n project (.vcxproj) , which allows me to compile the other languages without manually copying in a RES folder.
  3. LocalizeRC must have "Coy Resource Header and RES Folder" checkbox active, else it will not generate a console.rc file that is correctly built. This option is needed even if the RES folder is deleted and not needed for building.

For these reasons, no matter how many times I tried to rename console_AAA.rc to my language, it would simple be ignored without error. The same happened for console_FRA.rc, as it was not correctly compiled.

After all that work I completely forgot the "about" string. I'll have a look at that next.

@cbucher
Copy link
Owner Author

cbucher commented Feb 26, 2016

Thank you for your work. I fixed the build process. Copy of resource.h and RES folder is no longer required.

@rosolino
Copy link

rosolino commented Apr 8, 2016

Hello.
I upload Japanese localization file.
It is a small place that is the translation ...
JPN.zip

@cbucher
Copy link
Owner Author

cbucher commented Apr 8, 2016

@rosolino Hello,
Thank you for the translation.

Please do a pull request.
The identity of the translator must appear in the commit. I wish not be responsible for the translation. I will not control correctness of the translation and I will not maintain the translation.
You can add your name in the "about" window (the string can be found in console.ini).

@pcr-coding
Copy link

Sorry, but I have to mention that the german translation is very incomplete and full of bugs. There are many fundamental mistakes which make it almost unusable.

To mention only a few as example (I could mention numerous more): The menu Edit is never called Editieren in german. Everybody is used to find it as Bearbeiten. Or the Button Clone would never be called Klonen everybody would say Duplizieren. Button would never ever be called Knopf everybody knows it as Schaltfläche and so on.

Translators should at least follow some naming conventions, Windows users are used to! There should be some quality check (community based or something) before a language is included or at least the possibility to switch the language back to a good native english (I didn't find any option to switch the language, if it exists it must be lost in some strange german).

The german is unusable (at least for me). It looks like is was done by a translating software and not by a human thinking about it. Many words are translated word by word instead of meaningful translations as a human would do it or as you can find it in other softwares.

Yes I know I could fix it and do a pull request. But I think not doing any quality check (at least a community based) before including it into the stable release is a main problem that needs to be discussed!

//Edit:
OK I found out to delete the german dll results in falling back to english. But it would be nice to have the option to switch it in the settings of ConsoleZ. This is what users are used to and I don't have to change it on every software update.

@cbucher
Copy link
Owner Author

cbucher commented Apr 13, 2016

@pcr-coding You can contribute and correct the translation.

@cbucher
Copy link
Owner Author

cbucher commented Apr 14, 2016

OK I found out to delete the german dll results in falling back to english.

This is mentioned in FAQ section.

But it would be nice to have the option to switch it in the settings of ConsoleZ. This is what users are used to and I don't have to change it on every software update.

see FAQ (and #334)

ConsoleZ language loading follows Windows standard order: first the user language, second the system language and last the neutral language (english). Resource dlls, named (console_<(ISO 639-2/B>.dll), are optional. They can be renamed or deleted.

So:

  • If you prefer english language, be consistent and configure your user profile. In this case, you configure your preferred language for all Windows compliant applications.
  • If you dislike ConsoleZ translation: contribute and fix the translation! That is the goal of open source software. To fix the translation, you just need to edit an ini file and do a pull request.

@cbucher
Copy link
Owner Author

cbucher commented Apr 29, 2016

@ya158 @cruzzer @rosolino @pcr-coding Stable version should be released next week. Please, verify/complete/fix translations.

@cbucher
Copy link
Owner Author

cbucher commented Sep 10, 2016

@ya158 @cruzzer @rosolino @pcr-coding @ys-nuem Hi,
Stable version should be released next week. Please, verify/complete/fix translations.

@ya158
Copy link

ya158 commented Sep 12, 2016

I`m verify/complete/fix translations.

@cbucher
Copy link
Owner Author

cbucher commented Nov 11, 2016

@ya158 @cruzzer @rosolino @pcr-coding @ys-nuem Hi,
Stable version should be released next week. Please, complete translations.

@cbucher
Copy link
Owner Author

cbucher commented Feb 10, 2017

@ya158 @cruzzer @rosolino @pcr-coding @ys-nuem Hi,
version 1.18.0.17041-beta0 has been released
Stable version should be released next week.
Please, could you complete translations?

@madcampos
Copy link

Hi, I'm interested in translating for Brazilian-Portuguese. Will send a PR.

@cbucher
Copy link
Owner Author

cbucher commented Oct 9, 2017

@madcampos Hi, all translators/contributors are welcomed.
You will find localization documentation here.

Steps 4 to 6 require Visual Studio for building. Tell me if this is a problem.

@cbucher cbucher pinned this issue Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants