Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Upgrade dependencies to latest compatible versions, remove unneeded #15

Closed
4 tasks
brylie opened this issue Jan 25, 2022 · 6 comments · Fixed by #19
Closed
4 tasks

Upgrade dependencies to latest compatible versions, remove unneeded #15

brylie opened this issue Jan 25, 2022 · 6 comments · Fixed by #19
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents

Comments

@brylie
Copy link
Contributor

brylie commented Jan 25, 2022

Many of our direct dependencies are out of date. Most likely, some are no longer needed.

Task

  • audit our dependencies and remove any that are unneeded
  • run npm outdated
  • determine which dependencies can be safely updated
  • update the dependencies to the latest compatible versions
@brylie brylie added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Jan 25, 2022
@brylie brylie added good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents and removed 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 25, 2022
@sadn1ck
Copy link
Contributor

sadn1ck commented Jan 25, 2022

Are we still planning to keep storybook? It carries a bulk of dependencies all by itself (along with react as a dev dependency for some reason).

@brylie
Copy link
Contributor Author

brylie commented Jan 25, 2022

Yes, I believe we are planning to remove Storybook from this repository. Would you like to take this task and the Storybook removal?

@sadn1ck
Copy link
Contributor

sadn1ck commented Jan 25, 2022

What will we be migrating to? I believe we can go ahead with the dependency upgrades in the meanwhile, and decide what to migrate to.

Ideally migration can be done in another PR.

@brylie
Copy link
Contributor Author

brylie commented Jan 25, 2022

@sadn1ck see also: #16

Let's discuss the Storybook removal/migration in that issue.

@sadn1ck
Copy link
Contributor

sadn1ck commented Jan 25, 2022

Running npm update with node 16 resulted in an irreconciliable dependency conflict, and I'm hesitant to use --force, not sure what would break.

Log
❯ npm update
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @creativecommons/vocabulary-components@0.2.0
npm ERR! Found: react@16.14.0
npm ERR! node_modules/react
npm ERR!   dev react@"^16.13.1" from the root project
npm ERR!   peer react@"^16.8.0 || ^17.0.0" from @storybook/addons@6.4.14
npm ERR!   node_modules/@storybook/addons
npm ERR!     dev @storybook/addons@"^6.0.21" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"17.0.2" from react-dom@17.0.2
npm ERR! node_modules/react-dom
npm ERR!   peer react-dom@"^16.8.0 || ^17.0.0" from @storybook/addons@6.4.14
npm ERR!   node_modules/@storybook/addons
npm ERR!     dev @storybook/addons@"^6.0.21" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/anik/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/anik/.npm/_logs/2022-01-25T14_09_02_670Z-debug.log```

</details>

@brylie
Copy link
Contributor Author

brylie commented Jan 25, 2022

Further impetus to remove Storybook.

@cc-open-source-bot cc-open-source-bot added 🏷 status: label work required Needs proper labelling before it can be worked on and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Jan 26, 2022
@sadn1ck sadn1ck mentioned this issue Jan 28, 2022
7 tasks
@cc-open-source-bot cc-open-source-bot removed the 🏷 status: label work required Needs proper labelling before it can be worked on label Jan 29, 2022
@brylie brylie self-assigned this Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents
Development

Successfully merging a pull request may close this issue.

3 participants