Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can not make it work #5

Closed
iagobruno opened this issue Jun 15, 2018 · 9 comments
Closed

I can not make it work #5

iagobruno opened this issue Jun 15, 2018 · 9 comments

Comments

@iagobruno
Copy link

I'm doing all the steps that are described in the README but it just does not work :(

There are 3 types of errors:

  • "The path argument must be of type string" (look item image below)
  • "There were no tests exported": but the file "app.test.js" export functions
    image
  • "spawn UNKNOWN"
    image
@ccampbell
Copy link
Owner

This must be the same issue as #3. I do not have a windows machine to test on. I can see about getting a VM running. Would also be very happy to have some help debugging.

The spawn unknown error looks like it may have to be something related to how I am executing the node code when calling a child process:

https://stackoverflow.com/questions/43419893/how-do-i-fix-error-spawn-unknown-with-node-js-v7-8-0-on-windows-10

@ccampbell
Copy link
Owner

I am trying to get a windows VM installed to test it out

@ccampbell
Copy link
Owner

Okay I believe I got everything working. Publishing the new version to NPM now!

Fixed by d837f23, b2ece01, and 29c9792

@ccampbell
Copy link
Owner

I take it back there is one more issue related to the assertions. If assertions fail right now on windows they are not showing up as test failures. Hopefully I will figure it out shortly

@ccampbell
Copy link
Owner

And here is the final fix 70e626b

@iagobruno
Copy link
Author

Already ready to use and test? very quick

@ccampbell
Copy link
Owner

Yup if you try out version 1.0.5 it should work! The warning about using undefined for path is from npx, if you run it using ./node_modules/.bin/luna the warning should go away, but it doesn’t actually cause any problems.

The final error about no tests being exported I think may be an issue on your end, but I am not sure. Every exported test has to start with the word test. I just added a note to the docs:

https://github.com/ccampbell/luna#naming-tests

@ccampbell
Copy link
Owner

And there is also an issue where the emojis do not show up on windows, but I can’t do anything about that at the moment. Seems to be something they are working on

microsoft/terminal#190

@iagobruno
Copy link
Author

It's working for me now! thanks 👏

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants