Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ccao.class_dict table #362

Closed
dfsnow opened this issue Mar 26, 2024 · 1 comment
Closed

Update ccao.class_dict table #362

dfsnow opened this issue Mar 26, 2024 · 1 comment
Assignees
Labels
new data/feature Create or edit a column/feature or collect new data

Comments

@dfsnow
Copy link
Member

dfsnow commented Mar 26, 2024

The ccao.class_dict table in Athena is now relied on heavily for dbt tests and other references. However, it hasn't actually been touched in awhile and needs a good update. Here's what I'm thinking:

  • The class_dict table should be the internal source-of-truth for our class definitions. It should be the thing we reference in all documentation and tests.
  • We need to update class_dict to include new classes used in iasWorld (OA2, suffix letters, etc.)
  • I'll add the dictionary to PTAXSIM once it's finished, we can also add it to Open Data.
  • We should change the class_dict CSV to a dbt seed, as in Update cleanup_dbt_resources for seeds and fix location.neighborhood_group.nbhd type #348

@wrridgeway can do the legwork to find and collate the class codes, descriptions, and LoAs.
@jeancochrane can do the technical work to update tests, checks, and the seed.

This is a ton of work, so feel free to break it up into multiple issues.

CC @ccao-jardine

@dfsnow
Copy link
Member Author

dfsnow commented Apr 30, 2024

This was effectively closed by #397, with LoA stuff covered by #420.

@dfsnow dfsnow closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new data/feature Create or edit a column/feature or collect new data
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants