Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comparables vignette terminology + add section re: comparable stability #7

Open
3 tasks
dfsnow opened this issue Oct 2, 2023 · 0 comments
Open
3 tasks
Assignees
Labels
enhancement New feature or request

Comments

@dfsnow
Copy link
Member

dfsnow commented Oct 2, 2023

After sharing the comparables finding vignette with some folks, we received some good suggestions for improvement:

  • Change the term "target property" to "property of interest" since the former has a specific meaning in machine-learning contexts that doesn't apply here.
  • Add a final section to the vignette testing the stability of comparable scores across different hyperparameter settings and numbers of iterations. The idea here being, any comparables we derive using this method should be robust to different model structures, given enough iterations.
  • Look into random forest proximity scores and compare to this comps method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant