Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SqliteValueType to FMDBSqliteValueType #819

Open
ccgus opened this issue Mar 25, 2021 · 5 comments
Open

Rename SqliteValueType to FMDBSqliteValueType #819

ccgus opened this issue Mar 25, 2021 · 5 comments
Milestone
3.0

Comments

@ccgus
Copy link
Owner

ccgus commented Mar 25, 2021

These should probably have a prefix on them (and then export to swift with the current names)
@ccgus ccgus added this to the 3.0 milestone Mar 25, 2021
@robertmryan
Copy link
Collaborator

Oh, I get what you’re saying. I’m OK with adding FMDB prefix to SqliteValueType (though this is admittedly not backward compatible).

@robertmryan
Copy link
Collaborator

This SqliteValueType has been around for a while. I just moved it from FMDatabase.h to FMResultSet.h. That having been said, how many people were using that...

@robertmryan
Copy link
Collaborator

Let me know what you decide, and I’m happy to update #818 accordingly.

@robertmryan
Copy link
Collaborator

Or open a new PR ;)

@ccgus
Copy link
Owner Author

ccgus commented Mar 25, 2021

No need to do a PR anytime soon. I'm just spitballing ideas for 3.0, and the reason I targeted that was because it would break backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@ccgus @robertmryan