Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy to <2 for CI #750

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Pin numpy to <2 for CI #750

merged 3 commits into from
Aug 16, 2024

Conversation

ndevenish
Copy link
Collaborator

We will need to address this at some point soon, but for now just fix the CI.

@ndevenish ndevenish enabled auto-merge (squash) August 16, 2024 10:45
Hopefully the issue requiring 947753e is gone.

This was causing errors in the CI with conflicting libc++, gcc versions.
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.70%. Comparing base (3102224) to head (d9f5eea).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   41.75%   41.70%   -0.06%     
==========================================
  Files         188      188              
  Lines       16880    16922      +42     
  Branches     3233     3240       +7     
==========================================
+ Hits         7049     7058       +9     
- Misses       9181     9214      +33     
  Partials      650      650              

@ndevenish ndevenish merged commit f3635ad into cctbx:main Aug 16, 2024
12 of 13 checks passed
@ndevenish ndevenish deleted the fix_ci branch August 16, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants