Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break exchanges.py into separate files #233

Closed
jcrubino opened this issue Sep 25, 2017 · 2 comments
Closed

Break exchanges.py into separate files #233

jcrubino opened this issue Sep 25, 2017 · 2 comments
Assignees

Comments

@jcrubino
Copy link

jcrubino commented Sep 25, 2017

All in all this library is overwhelmingly impressive in bredth and syntatic niceties.

but exchanges.py is getting quite large

Would it be more ergonomic for developers to work on code files specified for each exchange and use explicit imports or concat through configuration every exchange needed for production environments into an exchanges.py?

This might lead to contributor ownership for individual or sets of exchanges and a standard if limited test suite could be used to score exchange code maturity.

@kroitor kroitor changed the title Break exchanges.py into seperate files for each exchange Break exchanges.py into separate files Sep 25, 2017
@kroitor
Copy link
Member

kroitor commented Sep 25, 2017

@jcrubino we're planning to refactor for that in the upcoming v2.0 very soon (it will be backward-compatible, though much better organized internally). Thx for your proposal! Stay tuned! We will update you on this.

@kroitor
Copy link
Member

kroitor commented Oct 31, 2017

This issue has been finally fixed in 1.9.291. Thx for all your patience!

@kroitor kroitor closed this as completed Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants