Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-315: Processing Queue ID as a long value #353

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

amehra
Copy link

@amehra amehra commented Jul 13, 2024

Queue ID retured from Jenkins can be a Long value. This is due to a recent update which resulted in the queue IDs returning a random long values instead of sequential integers. The jenkins-rest API expects this to be an Integer value. As a result, calls to jobsApi().buildWithParameters and then attempting to retrieve the queue ID will fail/return null.

This PR fixes the JobsApi and QueueApi to deal with the new long values.

Please refer to issue 315

closes #315

Queue ID retured from Jenkins can be a Long value. This is due to a recent update which resulted in the queue IDs returning a random long values instead of sequential integers. The jenkins-rest API expects this to be an Integer value. As a result, calls to jobsApi().buildWithParameters and then attempting to retrieve the queue ID will fail/return null.

This PR fixes the JobsApi and QueueApi to deal with the new long values.

Please refer to issue [315](cdancy#315)
@cdancy
Copy link
Owner

cdancy commented Jul 15, 2024

hey @amehra thanks for the PR! I'll look over this today and get back to you

@amehra
Copy link
Author

amehra commented Aug 8, 2024

hey @amehra thanks for the PR! I'll look over this today and get back to you

Hi @cdancy and @martinda. Any luck with the PR review. Please let me know if I can help in any way.

@cdancy cdancy merged commit 2e87dfc into cdancy:master Aug 9, 2024
2 checks passed
@amehra
Copy link
Author

amehra commented Aug 13, 2024

@cdancy thanks for merging the PR. What is the most effective way to release these changes so that I can incorporate them into my project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queue ID is returning from Jenkins as a Long value, not an Integer as expected by the jenkins-rest API
3 participants