Only enable SSE on non ARM systems #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you, pls make it pointing to develop |
autoantwort
force-pushed
the
arm-no-sse
branch
from
e5d8a70
to
b1dfc68
Compare
dg0yt
reviewed
Aug 15, 2023
Comment on lines
+53
to
+54
| cmake_policy(SET CMP0127 NEW) | ||
| cmake_dependent_option(OpenMVS_USE_SSE "Enable SSE optimizations" ON "NOT CMAKE_SYSTEM_PROCESSOR MATCHES \"^(arm|ARM|aarch64|AARCH64).\"" OFF) |
There was a problem hiding this comment.
Doesn't this implicitly raise the minimum required version to CMake 3.22?
Other policies are handled with guards in lines 7 to 15.
And the feature enabled by CMP0127 simples doesn't exist before CMake 3.22,
https://cmake.org/cmake/help/latest/policy/CMP0127.html
There was a problem hiding this comment.
thx for spotting this; can you modify the if to not require the new policy? if not lets update cmake version
There was a problem hiding this comment.
It should be enough to put the condition result into a variable, and use this variable value instead of the original ON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #921