-
-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: add Python utility for reading DMAP files #1059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Sep 16, 2023
•
edited by ghost
Loading
edited by ghost
- Moved python scripts to their own folder.
- Python utility for reading DMAP files.
- Example for reading DMAP file content.
ghost
changed the title
common: example for reading dmap files using python
common: python example for reading dmap files
Sep 18, 2023
ghost
changed the title
common: python example for reading dmap files
common: Python example for reading DMAP files
Sep 18, 2023
great work, this is so nice, thank you I do have two suggestions though:
|
ghost
changed the title
common: Python example for reading DMAP files
common: create Python utility for reading DMAP files
Sep 18, 2023
ghost
changed the title
common: create Python utility for reading DMAP files
common: add Python utility for reading DMAP files
Sep 19, 2023
cdcseacave
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks perfect now, thank you!
ghost
marked this pull request as draft
September 20, 2023 05:39
ghost
marked this pull request as ready for review
September 20, 2023 16:57
Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.