Fixes on SerDes (#682)

* Try catch serdes serialize and deserialize in order to avoid Internal Server Error and return BadRequest errors #601 * Fix incorrect serDes example #569
cdimascio · Dec 21, 2021 · 56f778b · 56f778b · cdimascio · Dec 21, 2021
1 parent 3f0de5d
commit 56f778b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -774,7 +774,7 @@ To create custom serializers and/or deserializers, define:
 e.g.
 
 ```javascript
-serDes: [{
+serDes: [
    // installs dateTime serializer and deserializer
   OpenApiValidator.serdes.dateTime,
   // installs date serializer and deserializer
@@ -784,8 +784,8 @@ serDes: [{
     format: 'mongo-objectid',
     deserialize: (s) => new ObjectID(s),
     serialize: (o) => o.toString(),
-  }
-}],
+  },
+],
 ```
 
 The mongo serializers will trigger on the following schema:

diff --git a/src/framework/ajv/index.ts b/src/framework/ajv/index.ts
@@ -55,7 +55,12 @@ function createAjv(
                   ];
                   return false;
                 }
-                obj[propName] = sch.deserialize(data);
+                try {
+                  obj[propName] = sch.deserialize(data);
+                }
+                catch(e) {
+                  return false;
+                }
               }
               return true;
             };
@@ -99,7 +104,12 @@ function createAjv(
             return function validate(data, path, obj, propName) {
               if (typeof data === 'string') return true;
               if (!!sch.serialize) {
-                obj[propName] = sch.serialize(data);
+                try {
+                  obj[propName] = sch.serialize(data);
+                }
+                catch(e) {
+                  return false;
+                }
               }
               return true;
             };