feat: add req to onError handler for response validation #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdimascio
approved these changes
Mar 21, 2021
|
@all-contributors add @0xCAFEADD1C7 for code and test |
|
I've put up a pull request to add @0xCAFEADD1C7! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
First of all thanks for this project, we've been using it in my company for some time now and it's really helpful 👍
The goal of this PR is simply to add the express request object to the
onErrorhandler for response validation. Our use case is that in case of error, we want to log the failing response with our logger, which is bound to the request (so that we have the request context), but I think that we can imagine a lot of useful use-cases to use the request here :)