feat: initial kubectl layer construct #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
commented
Sep 16, 2022
.projenrc.js
Outdated
| defaultReleaseBranch: 'main', | ||
| name: 'awscdk-asset-kubectl', | ||
| name: '@aws-cdk/asset-kubectl-v1-20', |
There was a problem hiding this comment.
Naming suggestions? @aws-cdk/asset-kubectl-v1.20 does not work. I don't know if people care about the minor version of kubectl here, maybe just @aws-cdk/asset-kubectl-v1 is sufficient?
There was a problem hiding this comment.
people do care about the minor version. Each minor version bump in kubernetes can have breaking changes. How about we borrow the convention from cdk8s-plus https://www.npmjs.com/package/cdk8s-plus-21
@aws-cdk/asset-kubectl-21 or @aws-cdk/asset-kubectl-v21
There was a problem hiding this comment.
Ok. Looks like this should be @aws-cdk/asset-kubectil-v20 then.
madeline-k
reviewed
Sep 19, 2022
No integ test in this module |
Signed-off-by: github-actions <github-actions@github.com>
madeline-k
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nearly a direct copy from https://github.com/aws/aws-cdk/tree/main/packages/%40aws-cdk/lambda-layer-kubectl with some changes to make it v2-compatible and projen-compatible.
Note: this exposes a
kubeCtlLayerconstruct, not the final formkubeCtlAsset. I figure it is better to start here and then update this repo in subsequent PRs. However, that means there are some inconsistencies with what I say this library exposes -- since this is not meant for active use right now, I feel like that is ok and will be corrected in a future PR.