feat: add KubectLayer and release as @aws-cdk/lambda-layer-kubectl-v25 #174
Conversation
Ok, will fix that later today. EDIT: Just realized you made a PR earlier 😅
Yes. Please check the screenshots attached and let me know whether the tests looks correct.
|
|
Thank you for the screenshots! They look perfect. I'm good with this PR, and once it's released, we can reference it in the CDK repo as an option. Edit: see ensuing comment. |
test/kubectl-layer.integ.snapshot/lambda-layer-kubectl-integ-stack.template.json
Outdated
Show resolved
Hide resolved
|
@CarlosDomingues thanks for your work so far :). We are basically done but as you can see, the lambda description was still referencing helm 3.10. I updated the description, but I think we're gonna get unlucky because the description is part of the lambda hash so the snapshot may need updating. Once that's updated, I shall approve! |
|
Just to confirm, do I need to re-deploy the project with the correct description to update the hashes and commit them? |
|
@CarlosDomingues nah, just snapshot update is ok in this case :) |
|
@CarlosDomingues @kaizencc Are we using helm 3.10.x just for backward support of k8s 1.22? https://helm.sh/docs/topics/version_skew/ |
|
Scratch my previous comment... I just saw that helm was brought up to 3.11.x which supports k8s 1.23.x - 1.26.x. Carry on :) |
Depends on cdklabs/awscdk-asset-kubectl#174 Closes #24282 https://aws.amazon.com/blogs/containers/amazon-eks-now-supports-kubernetes-version-1-25/ <img width="1299" alt="image" src="https://user-images.githubusercontent.com/31543/223216858-bad3062d-e839-4ebe-bb09-fc08c1c94358.png"> <img width="1561" alt="image" src="https://user-images.githubusercontent.com/31543/223236176-0ecf38ca-3a89-40bc-a97d-0a8f29b26329.png"> ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Depends on cdklabs/awscdk-asset-kubectl#174 Closes aws#24282 https://aws.amazon.com/blogs/containers/amazon-eks-now-supports-kubernetes-version-1-25/ <img width="1299" alt="image" src="https://user-images.githubusercontent.com/31543/223216858-bad3062d-e839-4ebe-bb09-fc08c1c94358.png"> <img width="1561" alt="image" src="https://user-images.githubusercontent.com/31543/223236176-0ecf38ca-3a89-40bc-a97d-0a8f29b26329.png"> ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds support for kubectl 1.25
Closes #166.