chore: tests are not isolated #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `upload external asset correctly` test was asserting that `PutObject` would be called twice, but it was only called twice because a test run prior to it leaked a `PubObject` invocation that was counted towards the count of this test. If the test was run by itself, the `PutObject` count was `1`, not `2`, and the test would fail.
otaviomacedo
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
upload external asset correctlytest was asserting thatPutObjectwould be called twice, but it was only called twice because a test run prior to it leaked aPubObjectinvocation that was counted towards the count of this test.If the test was run by itself, the
PutObjectcount was1, not2, and the test would fail.Also remove a log statement that breaks the linter in the new repo.