Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions added via another extension's addHooks() method have no access to scope #189

Open
joshlartz opened this issue Oct 14, 2022 · 0 comments
Open

Extensions added via another extension's addHooks() method have no access to scope #189

joshlartz opened this issue Oct 14, 2022 · 0 comments
Labels
bug Something isn't working p2

Comments

@joshlartz
Copy link
Contributor

Extensions that were added during the addHooks step won't have access to this.scope because the prehook step is in charge of setting scope and runs before addHooks.

https://github.com/cdklabs/cdk-ecs-service-extensions/blob/main/src/service.ts#L171,L180
@bvtujo bvtujo added bug Something isn't working p2 labels Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bvtujo @joshlartz