Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Close mid-service feedback when switching pages or submitting. #1434

Closed
anikbrazeau opened this issue Feb 18, 2020 · 2 comments · Fixed by #1478
Closed

Close mid-service feedback when switching pages or submitting. #1434

anikbrazeau opened this issue Feb 18, 2020 · 2 comments · Fixed by #1478
Assignees
@amazingphilippe
Labels
bug Something isn't working need for launch Cannot go live without this

Comments

@anikbrazeau
Copy link
Member

Summary

Mid-service feedback stays open when navigating the site.

Steps to reproduce

  1. click on "Is there something wrong on this page?"
  2. click continue

Screen Shot 2020-02-18 at 2 27 44 PM
@anikbrazeau anikbrazeau added bug Something isn't working needs prioritization We have to prioritize this issue need for launch Cannot go live without this and removed needs prioritization We have to prioritize this issue labels Feb 18, 2020
@sastels
Copy link
Contributor

sastels commented Feb 19, 2020

It’s because the midfeedback component is in App, not one of the pages in Home, so it doesn’t change when the page changes. If we move it onto every page then we should be good.

@sastels
Copy link
Contributor

sastels commented Feb 19, 2020

We should probably have some sort of PageLayout component that every page starts with, and contains the feedback and probably other things.

@amazingphilippe amazingphilippe self-assigned this Feb 20, 2020
@amazingphilippe amazingphilippe mentioned this issue Feb 20, 2020
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amazingphilippe amazingphilippe

Labels
bug Something isn't working need for launch Cannot go live without this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mid Feedback submit cds-snc/report-a-cybercrime
3 participants
@amazingphilippe @sastels @anikbrazeau