Prevent CI from masking version problem bugs #143
Conversation
| # If we passed a branch for cedar-policy, modify Cargo.toml to use that branch | ||
| - name: Replace Crates dot IO with Github version | ||
| if: "${{ inputs.cedar_policy_ref != '' }}" | ||
| run: cd cedar-rust-hello-world && printf "\n[patch.crates-io]\ncedar-policy = { git = 'https://github.com/cedar-policy/cedar.git', rev = '${{ inputs.cedar_policy_ref }}'}" >> Cargo.toml |
There was a problem hiding this comment.
I agree that we should fix CI to detect a mistake in versioning, but I think this code is necessary.
The intent of this step is that we should be able to submit a PR to cedar-policy and then check that cedar-examples builds and passes tests with the changes in the PR branch, so just building against the crates.io release won't work.
Maybe try removing
cedar-examples/.github/workflows/ci.yml
Line 59 in f94b5df
cedar-examples/.github/workflows/ci.yml
Line 67 in f94b5df
and
cedar-examples/.github/workflows/ci.yml
Line 75 in f94b5df
instead.
There was a problem hiding this comment.
I thought the convention is to use git as the source in cargo.toml files. So this replacement is unnecessary.
There was a problem hiding this comment.
But it needs to point to the correct git branch for a PR, not just the git main or release branch
There was a problem hiding this comment.
We don't want to do this.
The *reusable.yml tasks take in two branch names, one for cedar-policy and one for cedar-examples. We want this so a change to cedar-policy:releases/3.2.x can build against the 3.2 branch in cedar-examples.
For changes to cedar-examples, the ci.yaml file can point to the correct cedar_policy_ref.
This reverts commit 64cb5fe.
|
Let's use #149 |
The current CI hides version problems by overwriting the version of Cedar used.
This PR removes that functionality.