Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use Cedar JSON FFI where possible #181

Open
2 tasks
khieta opened this issue Jul 23, 2024 · 0 comments
Open
2 tasks

Re-use Cedar JSON FFI where possible #181

khieta opened this issue Jul 23, 2024 · 0 comments
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change

Comments

@khieta
Copy link
Contributor

khieta commented Jul 23, 2024

Category

Internal refactors/changes

Describe the feature you'd like to request

We made a variety of improvements to the Cedar JSON FFI (cedar-policy::ffi) as part of version 4.0. For example: we added APIs to check whether a policy/schema successfully parse (cedar-policy/cedar#1079), to apply the formatter to policies (cedar-policy/cedar#1087), and to convert between the JSON and Cedar syntaxes for policies and schemas (cedar-policy/cedar#1087).

The Java-Rust interface in CedarJavaFFI should reuse these FFI APIs as much as possible. For example: #172 and #180 could probably be revised to use the corresponding cedar-policy::ffi functions instead.

Describe alternatives you've considered

No response

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@khieta khieta added internal-improvement Refactoring, performance improvement, or other non-breaking change backlog labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change
Projects
None yet
Development

No branches or pull requests

2 participants