Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing Guava dependecy #86

Open
2 tasks
john-h-kastner-aws opened this issue Feb 15, 2024 · 0 comments · May be fixed by #88
Open
2 tasks

Consider removing Guava dependecy #86

john-h-kastner-aws opened this issue Feb 15, 2024 · 0 comments · May be fixed by #88
Labels
backlog We hope to work on this in the future internal-improvement Refactoring, performance improvement, or other non-breaking change work-in-progress Implementation work in progress

Comments

@john-h-kastner-aws
Copy link
Contributor

Category

Internal refactors/changes

Describe the feature you'd like to request

We use Guava for a few utility functions, but this pulls in a relativity larger dependency for some functions we could reasonably implement our selves.

When making this change, consider the differences between the builtin unmodifiable sets/maps and Guava's immutable data structures. In particular, the builtin types can be mutated by mutating a reference to the underlying set.

Previously removed in #81, but restored in #83.

Describe alternatives you've considered

.

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@john-h-kastner-aws john-h-kastner-aws added feature-request Request for a new feature pending-triage Hasn't been triaged yet pending-review Awaiting review by the core team and removed pending-triage Hasn't been triaged yet labels Feb 15, 2024
@john-h-kastner-aws john-h-kastner-aws linked a pull request Feb 19, 2024 that will close this issue
Draft
@john-h-kastner-aws john-h-kastner-aws linked a pull request Feb 19, 2024 that will close this issue
Re-remove dependency on Guava #88
Draft
@john-h-kastner-aws john-h-kastner-aws added work-in-progress Implementation work in progress backlog We hope to work on this in the future internal-improvement Refactoring, performance improvement, or other non-breaking change and removed pending-review Awaiting review by the core team feature-request Request for a new feature labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog We hope to work on this in the future internal-improvement Refactoring, performance improvement, or other non-breaking change work-in-progress Implementation work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-remove dependency on Guava cedar-policy/cedar-java
1 participant
@john-h-kastner-aws