Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving settings in multisite fails #119

Closed
tyrann0us opened this issue Jan 10, 2020 · 1 comment
Closed

Saving settings in multisite fails #119

tyrann0us opened this issue Jan 10, 2020 · 1 comment

Comments

@tyrann0us
Copy link
Contributor

Unfortunately, WordPress is not very consistent when it comes to naming files on single site vs. multisite. For example, there's no wp-admin/network/options.php file. But this very options.php is hardcoded in the plugin:

<form action="options.php" method="post">

Expectedly, saving SatisPress' settings in multisite won't work and triggers a 404.

Changing the line to this solves it but I'm not sure if it's the right approach:
<form action="<?php echo admin_url( 'options.php' ); ?>" method="post">

@bradyvercher
Copy link
Member

I guess that shows how often SatisPress is being used with multisite!

I've usually used a custom action for saving network settings, but if using admin_url() works, let's go with that. Would you like to submit a PR? If so, please throw esc_url() in there, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants