Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags do not appear in mobile web browser #9

Open
esmlima opened this issue Dec 30, 2022 · 11 comments
Open

Flags do not appear in mobile web browser #9

esmlima opened this issue Dec 30, 2022 · 11 comments
Assignees

Comments

@esmlima
Copy link

esmlima commented Dec 30, 2022

I don't understand why, but I'm facing different behaviour in flutter web projects when accessed from Desktop vs Mobile.

My demo project:
https://payment.gula.mobi/#/

On desktop it works fine:
image

On Android mobile, using Chrome:
Mobile Chrome

On Android mobile, using Firefox:
Mobile Firefox

On iPhone, using Safari:
iPhone Safari

@cedvdb
Copy link
Owner

cedvdb commented Dec 30, 2022

Good catch, hopefully someone can look into it. It might be due to svgs.

@arjittw
Copy link

arjittw commented Feb 1, 2023

Actually, they are not working in html renderer, only working in CanvasKit renderer. By default, flutter uses CanvasKit on desktop browsers and html renderer on mobile browsers.

@cedvdb
Copy link
Owner

cedvdb commented Feb 1, 2023

This might be due to the move to flutter-svg, as I recall it was working previously

@blopker
Copy link
Contributor

blopker commented Feb 9, 2023

Related: dnfield/flutter_svg#845

Yeah, looks like it's an issue with flutter_svg.

@blopker
Copy link
Contributor

blopker commented Feb 9, 2023

Made a PR, hope it helps: #11

@cedvdb
Copy link
Owner

cedvdb commented Feb 10, 2023

Thanks a lot @blopker I'll get on it this weekend, I'm drowning in high priority tasks right now

@cedvdb
Copy link
Owner

cedvdb commented Feb 19, 2023

should be fixed in 1.0.4

@cedvdb cedvdb closed this as completed Feb 19, 2023
@agordeev
Copy link

agordeev commented Apr 5, 2024

This issue happens again in 5.0.0

@cedvdb
Copy link
Owner

cedvdb commented Apr 5, 2024

the flags were regenerated with the original library https://github.com/HatScripts/circle-flags which readded the mask.

@cedvdb cedvdb reopened this Apr 5, 2024
@cyrilmata
Copy link

cyrilmata commented Apr 25, 2024

Hello, this issue happens again in 5.0.0, flutter_svg causes error in web release mode only
image

I rollback to previous version waiting for a fix :)

@cedvdb
Copy link
Owner

cedvdb commented Apr 25, 2024

@cyrilmata the original fix is linked above and can be reimplemented. Since the process has to be repeated each time the flags are regenerated, this should be implemented in a way that fixes the issues every time the files are regenerated.

This issue in the original repository would fix it at the source: HatScripts/circle-flags#105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants