Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestSquareSizeUpperBound_Flaky waited 10 blocks for tx to be included in block #2493

Closed
rootulp opened this issue Sep 13, 2023 · 2 comments
Closed

TestSquareSizeUpperBound_Flaky waited 10 blocks for tx to be included in block #2493

rootulp opened this issue Sep 13, 2023 · 2 comments
Labels
flake A test flake that occurred on Github CI

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 13, 2023

Problem

A test fails in CI a lot recently.

--- FAIL: TestSquareSizeIntegrationTest (70.42s)
    square_size_test.go:44: setting up square size integration test
    --- FAIL: TestSquareSizeIntegrationTest/TestSquareSizeUpperBound_Flaky (64.23s)
        --- FAIL: TestSquareSizeIntegrationTest/TestSquareSizeUpperBound_Flaky/gov_square_size_==_hardcoded_max (4.11s)
            square_size_test.go:195: 
                	Error Trace:	/home/runner/work/celestia-app/celestia-app/app/test/square_size_test.go:195
                	            				/home/runner/work/celestia-app/celestia-app/app/test/square_size_test.go:98
                	Error:      	Received unexpected error:
                	            	waited 10 blocks for tx to be included in block
                	Test:       	TestSquareSizeIntegrationTest/TestSquareSizeUpperBound_Flaky/gov_square_size_==_hardcoded_max
    full_node.go:181: tearing down testnode

Example. This test has been problematic in the past. See #2050

Proposal

Make the test less flaky in CI
@rootulp rootulp added bug Something isn't working testing items that are strictly related to adding or extending test coverage labels Sep 13, 2023
@evan-forbes
Copy link
Member

this might be related to #2454

@rootulp rootulp added flake A test flake that occurred on Github CI and removed bug Something isn't working testing items that are strictly related to adding or extending test coverage labels Jan 8, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Jan 8, 2024

Closing b/c hasn't reproed in a while.

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flake A test flake that occurred on Github CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @evan-forbes