Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove integration tests where possible to replace with unit #2533

Open
evan-forbes opened this issue Sep 18, 2023 · 0 comments
Open

Remove integration tests where possible to replace with unit #2533

evan-forbes opened this issue Sep 18, 2023 · 0 comments
Labels
refactor optional label for items that are related to implementation work and do not change functionality testapp directly relevant to testapp usage testing items that are strictly related to adding or extending test coverage

Comments

@evan-forbes
Copy link
Member

          I feel like we defer to using integration tests too often when unit tests would suffice

Originally posted by @cmwaters in #2515 (comment)

Unit tests are lighter, more precise, and easier to debug. We should reevaluate our rampant usage of the testnode integration tests and try to rewrite some of the tests with unit where possible.

We likely want to refactor our TestApp tooling so that its easier to write unit tests instead of having to resort to using integration tests just to execution transactions, have access to a mempool, or create new blocks.

@evan-forbes evan-forbes added testing items that are strictly related to adding or extending test coverage refactor optional label for items that are related to implementation work and do not change functionality and removed needs:triage labels Sep 18, 2023
@evan-forbes evan-forbes added the testapp directly relevant to testapp usage label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor optional label for items that are related to implementation work and do not change functionality testapp directly relevant to testapp usage testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

No branches or pull requests

1 participant