Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGB Orchestrator should stop signing if no longer in the valset #406

Closed
Tracked by #301
rach-id opened this issue May 13, 2022 · 2 comments · Fixed by #523
Closed
Tracked by #301

QGB Orchestrator should stop signing if no longer in the valset #406

rach-id opened this issue May 13, 2022 · 2 comments · Fixed by #523
Assignees
Labels
enhancement New feature or request

Comments

@rach-id
Copy link
Member

rach-id commented May 13, 2022

Currently, the QGB orchestrator keeps signing attestations even if it is not part of the valset. These signatures will be eventually rejected. Thus, the orchestrator should check if it is in the valset before signing attestations.

@rach-id rach-id added enhancement New feature or request C: QGB labels May 13, 2022
@evan-forbes
Copy link
Member

one point to note, is that a validator could potentially fall into and out of the validator set every other block, and ideally the orchestrator would be able to handle this as well, although this might be a premature feature.

@rach-id
Copy link
Member Author

rach-id commented May 13, 2022

100% it's still too early for this. Except that I wanted to keep track of all ideas so that after QGB 1.0, we have a list of improvements we can work on.
Btw, once the IT tests are set, let's go for a call to decide on the set of features we want for QGB 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants