Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an IntegrationTestSuite for the QGB IT #428

Closed
Tracked by #301
rach-id opened this issue May 21, 2022 · 2 comments
Closed
Tracked by #301

Add an IntegrationTestSuite for the QGB IT #428

rach-id opened this issue May 21, 2022 · 2 comments

Comments

@rach-id
Copy link
Member

rach-id commented May 21, 2022

Similar to #419, it would be better for the QGB to define an IntegrationTestSuite as it will allow removing a good number of repetitive lines of code, and it is more elegant.

@rach-id
Copy link
Member Author

rach-id commented May 25, 2022

Follow up:

With integration test suite:
Pros: remove 6 duplicate lines from each test and put them during integration test initialization.
Cons: not able to run the tests separately (they only run all of them).

Without integration test suite:
Pros: being able to run the tests separately and debug them separately
Cons: 6 additional initialization lines per test.

Does the ability to run tests separately (same as unit tests) worth an additional 6 lines per test ?

@rach-id
Copy link
Member Author

rach-id commented May 30, 2022

Current decision, stick with the current implementation without adding an integration test suite as the ability to run tests individually is really helpful at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants