Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QGB E2E use context and timeouts for stopping the network #438

Closed
Tracked by #301
rach-id opened this issue May 23, 2022 · 1 comment
Closed
Tracked by #301

QGB E2E use context and timeouts for stopping the network #438

rach-id opened this issue May 23, 2022 · 1 comment
Assignees
@rach-id

Comments

@rach-id
Copy link
Member

rach-id commented May 23, 2022

I definitely don't think we should change this in this PR, as its not even a nit pick just a different option, but we could simply rely on this context to cancel instead of a timeout channel. 🤷

Originally posted by @evan-forbes in #408 (comment)

We could rely also on timeouts to have multiple ways to stop the tests
@rach-id rach-id mentioned this issue May 23, 2022
Closed
90 tasks
@rach-id rach-id added the C: QGB label May 27, 2022
@rach-id rach-id mentioned this issue May 30, 2022
Merged
@rach-id rach-id self-assigned this May 30, 2022
@evan-forbes
Copy link
Member

closing w/ #459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rach-id @evan-forbes