-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QGB orchestrator signing everything before implementing slashing #479
Comments
@evan-forbes What do you think about this? |
this seems sane. we definitely don't want people to submit pointless signatures. as a side note, this could actually be implemented in a single transaction with many sdk.Msg, to sort of batch sign. |
Do we want this? I guess we decided in our last call to only sign up to the last unbonding period... |
The whole valset, except if the validator was not part of the valset for the entirety of it |
Okey cool then. Thanks a lot |
per sync discussion, this issue can be closed due to moving to v2 |
As discussed in #478 (comment)_, currently, the QGB orchestrator is implemented to sign attestations up to the last unbonding period. This makes sense when we have slashing, as after the unbonding period, if an orchestrator didn't sign it will already be slashed and no need to sign at that point.
However, before implementing slashing, there is no need to stop up to a certain height, as in testnets, we would want to have most attestations signed anyway.
Proposal: when an orchestrator is started, it goes over all the attestations where it was part of the valset and signs them (without having to worry about the last unbonding period).
The text was updated successfully, but these errors were encountered: