Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGB import Any type correctly #507

Closed
Tracked by #301
rach-id opened this issue Jun 26, 2022 · 4 comments
Closed
Tracked by #301

QGB import Any type correctly #507

rach-id opened this issue Jun 26, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@rach-id
Copy link
Member

rach-id commented Jun 26, 2022

Currently, in the QGB, we're defining the following query:

message QueryAttestationRequestByNonceResponse {
// AttestationRequestI is either a Data Commitment or a Valset.
// This was decided as part of the universal nonce approach under:
// https://github.com/celestiaorg/celestia-app/issues/468#issuecomment-1156887715
google.protobuf.Any attestation = 1
[ (cosmos_proto.accepts_interface) = "AttestationRequestI" ];
}

The problem is that the protobuf generated code type expects an implementation of Any under the celestia-app/codec/types.
As a simple hack, we're changing the import to use the cosmos-sdk implementation of Any:

types "github.com/cosmos/cosmos-sdk/codec/types"

However, we need to find a way to specify that dynamically so that we don't have to copy all the code from cosmos-sdk repo, or make the change manually every time we generate code.

@rootulp
Copy link
Collaborator

rootulp commented Sep 20, 2022

However, we need to find a way to specify that dynamically so that we don't have to copy all the code from cosmos-sdk repo, or make the change manually every time we generate code.

Do we want a new issue for this? I couldn't find one in #301

If we do create a new issue, then we may want to include a step to delete: https://github.com/celestiaorg/celestia-app/pull/742/files#diff-63113d53e02a4e334ffa1a1ba0c308329c7acd431153571a2c02ce9268af5816R28-R32

@rach-id
Copy link
Member Author

rach-id commented Sep 20, 2022

Sure sounds good. want me to create the issue? or you wanna do it yourself?

@rootulp
Copy link
Collaborator

rootulp commented Sep 20, 2022

Just created #744 and added it as a Nice to have, high priority in the tracking issue.

@rach-id
Copy link
Member Author

rach-id commented Sep 20, 2022

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants