Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QGB start valset nonce at 0 instead of 1 #521

Closed
Tracked by #301
rach-id opened this issue Jul 5, 2022 · 1 comment
Closed
Tracked by #301

QGB start valset nonce at 0 instead of 1 #521

rach-id opened this issue Jul 5, 2022 · 1 comment
Assignees
@rach-id

Comments

@rach-id
Copy link
Member

rach-id commented Jul 5, 2022

Currently, the first valset attestation that is created by the state machine has a nonce of 1. This is not consistent with the QGB smart contract which initializes the attestation count with 0.
Thus, the state machine also should state at 0.
@rach-id rach-id added the C: QGB label Jul 5, 2022
@rach-id rach-id mentioned this issue Jul 5, 2022
Closed
90 tasks
@rach-id
Copy link
Member Author

rach-id commented Jul 25, 2022 •
edited
Loading

Fixed. We're currently passing the nonce we want the QGB contract to be initialized at here #556

@rach-id rach-id closed this as completed Jul 25, 2022
@rach-id rach-id self-assigned this Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rach-id