Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGB state machine confirm signed by validator #638

Closed
4 tasks
Tracked by #301
rach-id opened this issue Aug 19, 2022 · 1 comment · Fixed by #646
Closed
4 tasks
Tracked by #301

QGB state machine confirm signed by validator #638

rach-id opened this issue Aug 19, 2022 · 1 comment · Fixed by #646
Assignees
Labels
bug Something isn't working

Comments

@rach-id
Copy link
Member

rach-id commented Aug 19, 2022

Summary of Bug

Currently, the QGB queries the validator by orchestrator to check if the validator was registered.
However, this check only checks the current set of validators. Thus, submitting confirms for old valsets can fail even if they are correct:

validator, found := k.StakingKeeper.GetValidatorByOrchestrator(ctx, orchaddr)

This will need to be fixed.

Version

d63b998

Steps to Reproduce

not needed.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@rach-id rach-id added bug Something isn't working C: QGB labels Aug 19, 2022
@rach-id rach-id self-assigned this Aug 22, 2022
@rach-id
Copy link
Member Author

rach-id commented Aug 22, 2022

Following the decision taken on #631, this check will need to be deleted also as we will no longer iterate over valsets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant