-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider treating namespaced padding as blobs or sequences #783
Comments
Afaik this would only break the second property for the first padding share, as it has different message lengths. However, the length of the padding should also be transmitted in the p2p layer regardless of this change, so I think it doesn't break the second property at all. |
In order for this to be the case, additional metadata must be added to the share so that a client can differentiate between a sequence of namespaced padding shares and a sequence of shares with |
Assuming that all padding shares have a start indicator of 1, and data len of 0, then shouldn't you be able to differentiate padding shares from non-padding shares, because only padding shares can have a start indicator of 1 and data len of 0? |
Good point. celestia-app denies blob sizes of Pros:
Cons:
|
Implements the proposal in #783 (comment). Closes #1136 Closes #783 Opens #1344 --------- Co-authored-by: Callum Waters <cmwaters19@gmail.com>
I think they can learn that using the method described in: #1136 (comment) (cc @adlerjohn)
|
Implements the proposal in #783 (comment). Closes #1136 Closes #783 Opens #1344 --------- Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Implements the proposal in celestiaorg/celestia-app#783 (comment). Closes celestiaorg/celestia-app#1136 Closes celestiaorg/celestia-app#783 Opens celestiaorg/celestia-app#1344 --------- Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Implements the proposal in celestiaorg/celestia-app#783 (comment). Closes celestiaorg/celestia-app#1136 Closes celestiaorg/celestia-app#783 Opens celestiaorg/celestia-app#1344 --------- Co-authored-by: Callum Waters <cmwaters19@gmail.com>
With the non-interactive defaults, we introduced padding between messages. Per the original specs
Caveats
section of Message Layout Rational, these are described asWe should consider updating the implementation and specs to treat the each section of padding as individual messages. This will prepend an info byte along with a length delimiter.
edit:
While the added bytes would break the second property,this might mean that light clients could skip these shares entirely when parsing a namespace.
The text was updated successfully, but these errors were encountered: